Define requirements in composer.json#3754
Draft
fredden wants to merge 2 commits intosquizlabs:masterfrom
Draft
Conversation
Contributor
|
@fredden Thanks for the PR. I can't say anything about whether it will be accepted or not, but can give you some feedback in general terms, but in the end, it's @gsherwood's decision.
Sorry to be a party-pooper. |
Contributor
Author
Would it be helpful for me to open pull requests for each of the identified extensions, and add a "conditional use" check around these? We could then move these extensions from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following some feedback on #3752 about an extension that I'd forgotten to add to
composer.json, I have set upmaglnet/composer-require-checkerto automatically detect such errors in future. While doing so, I noticed that the following extensions are already required, but were not listed incomposer.json:ctype-PHP_CodeSniffer/src/Tokenizers/JS.php
Line 859 in add95a7
dom-PHP_CodeSniffer/src/Generators/Generator.php
Line 93 in add95a7
iconv-PHP_CodeSniffer/src/Reports/Xml.php
Line 57 in add95a7
json-PHP_CodeSniffer/src/Util/Cache.php
Line 291 in add95a7
libxml-PHP_CodeSniffer/src/Ruleset.php
Line 324 in add95a7
Additionally, there was no
autoloadsection incomposer.json, which I have now added.I had to create configuration for the checker tool to avoid it complaining about a large number of (global) constants that are defined here.